macOS: Use objc2 crates
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
commented
Apr 24, 2024
Comment on lines
12
to
15
| pub fn activate_cocoa_multithreading() { | ||
| unsafe { | ||
| let thread: *mut Object = msg_send![class!(NSThread), new]; | ||
| let _: () = msg_send![thread, start]; | ||
| } | ||
| let thread = NSThread::new(); | ||
| unsafe { thread.start() }; | ||
| } |
There was a problem hiding this comment.
An example of yet another improvement: This function was previously leaking, as the NSThread wasn't released at the end of the scope. objc2 instead handles this kind of memory management for you automatically.
61 tasks
These replace the `objc` family of crates, and provide a bunch of improvements on top of it. Improvements relevant for `rfd`: - No longer need to call `msg_send!`, (almost) all methods have automatically generated bindings in `objc2-foundation`. - `MainThreadMarker`, allows marking explicitly the functions that must run on the main thread. - Blocks in `block2` have correct memory management, you no longer need to call `mem::forget`. - AppKit bindings are provided in `objc2-app-kit`, you no longer need to define `NSApplication`, `NSAlertStyle` and such manually. To do this change, I had to change how `AsModal` works, as it was previously relying on the fact that `NSAlert` and `NSSavePanel` just so happened to have mostly compatible methods; now we ensure statically that the correct method is called.
macos-latest is now macos-14, which runs on aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These replace the
objcfamily of crates, and provide a bunch of improvements on top of it.Improvements relevant for
rfd:msg_send!, (almost) all methods have automatically generated bindings inobjc2-foundation.MainThreadMarker, allows marking explicitly the functions that must run on the main thread.block2have correct memory management, you no longer need to callmem::forget.objc2-app-kit, you no longer need to defineNSApplication,NSAlertStyleand such manually.To do this change, I had to change how
AsModalworks, as it was previously relying on the fact thatNSAlertandNSSavePaneljust so happened to have mostly compatible methods; now we ensure statically that the correct method is called.Please do ask if there's anything about either the crates or the code here that's unclear!